Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass the global ctx to the handler plugins #683

Merged
merged 2 commits into from
Sep 28, 2023
Merged

pass the global ctx to the handler plugins #683

merged 2 commits into from
Sep 28, 2023

Conversation

kpacha
Copy link
Member

@kpacha kpacha commented Sep 13, 2023

as requested at krakend/krakend-ce#780

@kpacha kpacha requested a review from taik0 September 13, 2023 16:31
@fxedel
Copy link

fxedel commented Sep 17, 2023

Great, thank you! Could you also apply this to HTTP client plugins? I think it should be

handler, err := hf(context.Background(), extra)

…le to cancel from a client plugin.

Signed-off-by: Daniel Ortiz <[email protected]>
@kpacha kpacha merged commit 691640c into master Sep 28, 2023
2 checks passed
@kpacha kpacha deleted the plugin_ctx branch September 28, 2023 15:34
Copy link

This pull request was marked as resolved a long time ago and now has been automatically locked as there has not been any recent activity after it. You can still open a new issue and reference this link.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants