Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Add Codecov and update readme #53

Merged
merged 3 commits into from
Dec 26, 2022

Conversation

luongvo
Copy link
Owner

@luongvo luongvo commented Dec 24, 2022

What happened 👀

  • Integrate CodeCov for CI workflow to show code coverage in PR & README.
  • Add exclude rules for Kover.
  • Update README.

Insight 📝

There is an issue with CodeCov that it does not show code coverage correctly for Kotlin Multiplatform yet

Proof Of Work 📹

@luongvo luongvo added this to the 0.2.0 milestone Dec 24, 2022
@luongvo luongvo self-assigned this Dec 24, 2022
@luongvo luongvo force-pushed the feature/8-login-integration branch from b36e729 to b610a82 Compare December 24, 2022 08:55
@github-actions
Copy link

github-actions bot commented Dec 24, 2022

15 Warnings
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ android/src/main/java/vn/luongvo/kmm/survey/android/ui/common/Toaster.kt#L14 - Toast created but not shown: did you forget to call show() ?
⚠️ android/src/main/java/vn/luongvo/kmm/survey/android/ui/screens/login/LoginScreen.kt#L35 - Function parameter viewModel is unused.
⚠️ android/src/main/java/vn/luongvo/kmm/survey/android/ui/screens/login/LoginScreen.kt#L57 - The function LoginScreenContent is too long (70). The maximum length is 60.
⚠️ android/src/main/res/drawable/bg_login.jpg#L0 - Found bitmap drawable res/drawable/bg_login.jpg in densityless folder
⚠️ android/src/main/res/mipmap-hdpi/ic_launcher_round.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/main/res/mipmap-ldpi/ic_launcher.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/main/res/mipmap-mdpi/ic_launcher.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/main/res/mipmap-mdpi/ic_launcher_round.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png#L0 - Launcher icon used as round icon did not have a circular shape
⚠️ android/src/staging/res/mipmap-hdpi/ic_launcher_round.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/staging/res/mipmap-ldpi/ic_launcher.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/staging/res/mipmap-mdpi/ic_launcher.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/staging/res/mipmap-mdpi/ic_launcher_round.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/staging/res/mipmap-xxxhdpi/ic_launcher_round.png#L0 - Launcher icon used as round icon did not have a circular shape

🧛 build Code Coverage: 5.28%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

README.md
build.gradle.kts
build.gradle.kts
review_pull_request.yml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@luongvo luongvo changed the base branch from feature/8-login-integration to develop December 24, 2022 09:32
@luongvo luongvo force-pushed the chore/add-codecov-and-update-readme branch 2 times, most recently from f29d691 to ee22722 Compare December 24, 2022 09:36
@luongvo luongvo marked this pull request as ready for review December 24, 2022 09:37
@luongvo luongvo added the @0.2.0 label Dec 24, 2022
@luongvo luongvo force-pushed the chore/add-codecov-and-update-readme branch from ee22722 to b76883e Compare December 24, 2022 17:32
@luongvo luongvo changed the base branch from develop to feature/7-login-backend-save-credentials December 24, 2022 17:32
@luongvo luongvo force-pushed the chore/add-codecov-and-update-readme branch 4 times, most recently from 7951bac to b76883e Compare December 24, 2022 19:03
Repository owner deleted a comment from codecov-commenter Dec 24, 2022
Base automatically changed from feature/7-login-backend-save-credentials to develop December 26, 2022 02:49
@luongvo
Copy link
Owner Author

luongvo commented Dec 26, 2022

This's a small chore so I will merge this with 1 approval, please don't hesitate to put a comment even after merging.

@luongvo luongvo merged commit d09391f into develop Dec 26, 2022
@luongvo luongvo deleted the chore/add-codecov-and-update-readme branch December 26, 2022 02:55
@luongvo luongvo mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants