Patch onnxruntime to compile with clang-cl

[kokulshan]

Changes

Add some patches to the onnxruntime port to handle issues with llvm-rc and clang-cl related to unicode in the rc file and clang-cl needing simd flags enabled when compiling SIMD code.
...

Triplet Support

• x64-windows (MSVC and Clang-Cl)

[luncliff]

Appreciate your work, @kokulshan .
I was watching microsoft/vcpkg#31028 and clang-cl support will be followed in the registry after it.

I will test the update soon. 🏃

[luncliff]

@kokulshan Would you comment your triplet content?
Future visitors may be helped with it.

This is what I used

set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE dynamic)

# check https://github.com/microsoft/vcpkg/pull/31028
set(VCPKG_ENV_PASSTHROUGH_UNTRACKED "VCPKG_ROOT")
find_file(VCPKG_CHAINLOAD_TOOLCHAIN_FILE NAMES "scripts/toolchains/clangcl.cmake" HINTS "$ENV{VCPKG_ROOT}" NO_DEFAULT_PATH REQUIRED)

set(VCPKG_LOAD_VCVARS_ENV ON)
# For ports which uses Visual Studio. Not for Ninja
# set(VCPKG_PLATFORM_TOOLSET "ClangCL")

if(VCPKG_TARGET_ARCHITECTURE STREQUAL "x86")
    set(VCPKG_CXX_FLAGS "-m32")
elseif(VCPKG_TARGET_ARCHITECTURE STREQUAL "x64")
    set(VCPKG_CXX_FLAGS "-m64")
elseif(VCPKG_TARGET_ARCHITECTURE STREQUAL "arm")
    set(VCPKG_CXX_FLAGS "--target=arm-pc-windows-msvc")
elseif(VCPKG_TARGET_ARCHITECTURE STREQUAL "arm64")
    set(VCPKG_CXX_FLAGS "--target=arm64-pc-windows-msvc")
endif()
# prevent CMake to insert semicolon
set(VCPKG_CXX_FLAGS "-fms-compatibility ${VCPKG_CXX_FLAGS}")
set(VCPKG_C_FLAGS   ${VCPKG_CXX_FLAGS})

In the clangcl.cmake,

# ...
find_program(CMAKE_CXX_COMPILER NAMES clang-cl REQUIRED)
find_program(CMAKE_C_COMPILER NAMES clang-cl REQUIRED)
find_program(CMAKE_AR NAMES llvm-lib REQUIRED)
find_program(CMAKE_RC NAMES llvm-rc REQUIRED)
# find_program(CMAKE_LINKER NAMES lld-link REQUIRED)
# ...

[kokulshan]

@kokulshan Would you comment your triplet content? Future visitors may be helped with it.

I cannot share my triplet or toolchain file due to it having a bunch of work specific stuff in there. But it is very similar to your example toolchain file. Two differences are that I explicilty set the C and CXX flags for clang to /ARCH:AVX2 for our code and we also set the linker to lld-link

[luncliff]

That's OK. Feel free to suggest new PR if you meet another errors 👍