Skip to content

Commit

Permalink
fix: remove event listeners when dragging across iframe borders
Browse files Browse the repository at this point in the history
  • Loading branch information
luncheon committed Sep 18, 2022
1 parent fb573e8 commit 4eaf698
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 4 additions & 6 deletions src/pointer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,18 +17,16 @@ addEventListener("pointerdown", (pointerDownEvent: PointerEvent) => {
? (event) => event.pointerId === pointerId && move(event.clientX - pointerDownEvent.clientX)
: (event) => event.pointerId === pointerId && move(event.clientY - pointerDownEvent.clientY);

const onPointerUp = (event: PointerEvent) => {
const onLostPointerCapture = (event: PointerEvent) => {
if (event.pointerId === pointerId) {
separator.removeEventListener("pointermove", onPointerMove);
separator.removeEventListener("pointerup", onPointerUp);
separator.removeEventListener("pointercancel", onPointerUp);
separator.removeEventListener("lostpointercapture", onLostPointerCapture);
}
};
}

onPointerMove(pointerDownEvent);

separator.addEventListener("pointercancel", onPointerUp);
separator.addEventListener("pointerup", onPointerUp);
separator.addEventListener("lostpointercapture", onLostPointerCapture)
separator.addEventListener("pointermove", onPointerMove);
separator.setPointerCapture(pointerId);

Expand Down

0 comments on commit 4eaf698

Please sign in to comment.