Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cached if there are no cached results #545

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cached if there are no cached results #545

wants to merge 2 commits into from

Conversation

sapzape
Copy link
Contributor

@sapzape sapzape commented Dec 5, 2017

If there is no matching response in caches, fetch the request from the network,
then add a clone of the request to it using cache.put.

ISSUE=#534

romandev
romandev reviewed Dec 20, 2017
View reviewed changes
Copy link
Member

@romandev romandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch includes lint error fixes as well, right?
If so, please separate them from this patch. It makes code review difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romandev romandev romandev left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapzape @romandev