Add bodyParser #515
Add bodyParser #515
Conversation
server/base/application.ts
Outdated
| this.app.use(express.static(path.join(__dirname, '../client'))); | ||
| this.app.use(bodyParser.json({limit: '10mb'})); |
There was a problem hiding this comment.
JSON is limited under 100KB as default.
Default size is not enough to handling big-data through JSON.
There was a problem hiding this comment.
So, is there any use case in this patch?
If you have an use case, then please add it.
Otherwise, IMHO, remove it.
server/base/application.ts
Outdated
| this.app.use(express.static(path.join(__dirname, '../../out/client'))); | ||
| this.app.use(bodyParser.json({limit: '10mb'})); |
server/example/example.router.ts
Outdated
| @@ -22,4 +22,15 @@ export class Test { | |||
| public get(request: express.Request, response: express.Response): void { | |||
| response.send('hello world'); | |||
| } | |||
| public post(request: express.Request, response: express.Response): void { | |||
| if (request.body) { | |||
| if (request.body.userId === 'absolute') { | |||
There was a problem hiding this comment.
Why userId? I think we need a better name for example.
hyungheo
force-pushed
the
Add_bodyParser
branch
from
0064058
to
4dd9ba7
Compare
|
Express (>4.0) needs body-Parser to parse request.body which has a specific data such as json or x-www-form-urlencoded when it's handling a POST. |
|
@hyungheo I understand your words. Thank you for explanation. |
hyungheo
force-pushed
the
Add_bodyParser
branch
2 times, most recently
from
18c13d1
to
f9bbf8d
Compare
There was a problem hiding this comment.
Also, there are some lint errors in this patch.
https://travis-ci.org/lunchclass/absolute/jobs/302789423
server/base/application.ts
Outdated
| this.app.use(express.static(path.join(__dirname, '../client'))); | ||
| this.app.use(bodyParser.json({limit: '10mb'})); |
There was a problem hiding this comment.
So, is there any use case in this patch?
If you have an use case, then please add it.
Otherwise, IMHO, remove it.
hyungheo
force-pushed
the
Add_bodyParser
branch
4 times, most recently
from
e7a580c
to
57678c8
Compare
Add bodyParser Module and Test It is needed for handling a request as post ISSUE=lunchclass#458
hyungheo
force-pushed
the
Add_bodyParser
branch
from
57678c8
to
1310f1e
Compare
Add bodyParser Module and Test
It is needed for handling a request of post
ISSUE=#458