Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't change color on empty lines #11

Closed
wants to merge 5 commits into from
Closed

Conversation

obfusk
Copy link
Contributor

@obfusk obfusk commented Jun 18, 2020

fixes #24

@obfusk
Copy link
Contributor Author

obfusk commented Jun 19, 2020

Screenshot from 2020-06-19 15-16-31 cleaned

@landfillbaby
Copy link
Contributor

this doesn't fix in the case of a line containing only spaces or tabs

@obfusk
Copy link
Contributor Author

obfusk commented Jun 19, 2020

this doesn't fix in the case of a line containing only spaces or tabs

Fixed.

@obfusk
Copy link
Contributor Author

obfusk commented Jun 21, 2020

Closing b/c @landfillbaby has a better version.

@obfusk obfusk closed this Jun 21, 2020
@landfillbaby
Copy link
Contributor

oh ok i'll make a pr for mine then :)

@obfusk
Copy link
Contributor Author

obfusk commented Jun 21, 2020

@landfillbaby You can use Co-authored-by to share the credit if you want :)

@landfillbaby
Copy link
Contributor

landfillbaby commented Jun 21, 2020

i think that's just for single commits, unless we squash them i think having your name on your commits is ok? i was originally planning on having you merge my changes into your branch and then that being merged into the original

@obfusk
Copy link
Contributor Author

obfusk commented Jun 21, 2020

@landfillbaby I assumed squashing the commits for a new PR would be cleaner. Either way is fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

empty/blank lines result in "missing" colors
2 participants