fix: views (#428)

lunary-ai · Jul 17, 2024 · 14c753a · 14c753a
1 parent b8fcd30
commit 14c753a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 13 deletions.
diff --git a/packages/frontend/pages/logs/index.tsx b/packages/frontend/pages/logs/index.tsx
@@ -229,12 +229,15 @@ export default function Logs() {
     clearOnDefault: true,
   })
 
+  const { view, update: updateView, remove: removeView } = useView(viewId)
+
   const serializedChecks = useMemo(() => {
+    if (view) {
+      return serializeLogic(view.data)
+    }
     const checksWithType = editCheck(checks, "type", { type })
     return serializeLogic(checksWithType)
-  }, [checks, type])
-
-  const { view, update: updateView, remove: removeView } = useView(viewId)
+  }, [checks, type, view])
 
   const { evaluators } = useEvaluators()
 
@@ -255,7 +258,6 @@ export default function Logs() {
     if (type === "llm" && Array.isArray(evaluators)) {
       for (const evaluator of evaluators) {
         const id = "enrichment-" + evaluator.id
-        console.log(id)
 
         if (newColumns.llm.map(({ accessorKey }) => accessorKey).includes(id)) {
           continue
@@ -367,15 +369,15 @@ export default function Logs() {
 
       const newView = await insertView({
         name: "New View",
-        data: checks,
+        data: editCheck(checks, "type", { type }),
         columns: visibleColumns,
         icon,
       })
 
       setViewId(newView.id)
     } else {
       await updateView({
-        data: checks,
+        data: editCheck(checks, "type", { type }),
         columns: visibleColumns,
       })
 
@@ -559,12 +561,14 @@ export default function Logs() {
                   </Menu>
                 </Group>
               )}
-              <CheckPicker
-                minimal
-                value={checks}
-                onChange={setChecks}
-                restrictTo={(f) => CHECKS_BY_TYPE[type].includes(f.id)}
-              />
+              {!view && (
+                <CheckPicker
+                  minimal
+                  value={checks}
+                  onChange={setChecks}
+                  restrictTo={(f) => CHECKS_BY_TYPE[type].includes(f.id)}
+                />
+              )}
             </Group>
             {!!showSaveView && (
               <Button

diff --git a/packages/frontend/utils/dataHooks/views.ts b/packages/frontend/utils/dataHooks/views.ts
@@ -25,7 +25,7 @@ export function useViews() {
   }
 }
 
-export function useView(id?: string, initialData?: any) {
+export function useView(id: string | null, initialData?: any) {
   const { mutate: mutateViews } = useViews()
 
   const {