Support selection of the highest tax rate in the basket for shipping #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Any thoughts on this one? |
glennjacobs
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the shipping tables add-on only supports returning the default tax class/rate.
However countries can have different requirements for how tax should be calculated on shipping depending on what is in the basket, for example in the UK shipping should take the most expensive tax rate in the basket.
This PR updates the add-on with a new config option (
lunar.shipping-tables.shipping_rate_tax_calculation) which currently has two options:defaultfor selecting the default rate, orhighestfor selecting the highest rate in the basket.