Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instagram#1430 +:
master
inCHANGELOG
return
tocollectionView:contextMenuConfigurationForItemAt:point:
as per this commentUITargetedPreview
)collectionViewDelegate
of theIGListAdapter
or section controllers (see this comment).indexPath
when asked about context menu configuration it's easy to grab the appropriate section controller.ChatViewController
I usedconfiguration.identifier = indexPath as NSCopying
to be able to figure out for which message the preview is. Here we can't really do that — it's the delegate who should be able to set their own identifier, we can't override it in library.NSMapTable
with weak keys and weak values — as long as configuration and section controller are used/remembered/retained by other objects we will remember them in the table. As long as they are to be forgotten – they are since the references we hold are weak.