Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add estimateGas test #135

Merged
merged 3 commits into from
Apr 2, 2024
Merged

fix: Add estimateGas test #135

merged 3 commits into from
Apr 2, 2024

Conversation

richtera
Copy link
Contributor

@richtera richtera commented Oct 3, 2023

Ticket ID

https://app.clickup.com/t/2645698/DEV-8380

Description

Add Estimate Gas button and implement

Remove passing DEFAULT_GAS and DEFAULT_GAS_PRICE everywhere.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

@richtera
Copy link
Contributor Author

richtera commented Oct 4, 2023

This can be used with https://github.com/lukso-network/universalprofile-extension/pull/990 to call estimateGas on the extension and return a value.

@frozeman
Copy link
Member

frozeman commented Oct 4, 2023

@richtera
Copy link
Contributor Author

@jnorbert jnorbert requested a review from andyogaga October 18, 2023 07:28
@franckwei franckwei requested a review from Hugoo October 26, 2023 16:12
Copy link
Contributor

@dzbo dzbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's merge if ready

@frozeman
Copy link
Member

frozeman commented Apr 2, 2024

@richtera richtera merged commit 975cbad into main Apr 2, 2024
1 check passed
@richtera richtera deleted the fix/work-on-gas-estimate branch April 2, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants