Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LSP12 Issued Assets Scripts #56

Merged
merged 8 commits into from
Jul 30, 2024
Merged

Update LSP12 Issued Assets Scripts #56

merged 8 commits into from
Jul 30, 2024

Conversation

fhildeb
Copy link
Contributor

@fhildeb fhildeb commented Apr 10, 2024

Maintenance

Features

  • Updates scripts to use .env variables instead of plain script constants
  • Adds LSP12 script to dynamically add, remove, or update assets

Tests

✅ LSP12 Registration
✅ LSP12 Updates: Add new addresses to the list/map
✅ LSP12 Updates: Add existing addresses - will skip already existing ones

@fhildeb fhildeb requested a review from YamenMerhi May 27, 2024 16:58
@YamenMerhi YamenMerhi marked this pull request as draft July 23, 2024 13:04
@YamenMerhi
Copy link
Member

Will takeover

@YamenMerhi YamenMerhi marked this pull request as ready for review July 30, 2024 09:31
@@ -31,7 +31,6 @@
"isomorphic-fetch": "^3.0.0",
"prettier": "^3.2.4",
"prettier-plugin-solidity": "^1.3.1",
"typescript": "^5.3.3",
"@lukso/eip191-signer.js": "^0.2.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup 👌🏻

@CJ42 CJ42 merged commit efb63e7 into main Jul 30, 2024
1 check passed
@CJ42 CJ42 deleted the update-issued-assets branch July 30, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants