Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete comments related to Metamask + improve standard detection README #30

Merged
merged 2 commits into from
Feb 2, 2024
+15 −10
Merged

Delete comments related to Metamask + improve standard detection README #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d6851c
remove references to Metamask and Ethereum
CJ42 Feb 2, 2024
bd139da
improve links for interface and metadata standard
CJ42 Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions digital-assets/regular-token-transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import { ethers } from 'ethers';
import LSP7Mintable from '@lukso/lsp-smart-contracts/artifacts/LSP7Mintable.json';

// Connect to Ethereum via MetaMask or similar
// Connect to LUKSO via Browser Extension
// @ts-expect-error This is for the browser
const provider = new ethers.BrowserProvider(window.ethereum);
const provider = new ethers.BrowserProvider(window.lukso);

try {
// Request user's permission to connect and access their accounts
Expand Down
15 changes: 10 additions & 5 deletions metadata-detection/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
# Metadata detection

Before interacting with a smart contract, you might need to check if the contract supports the right standards.
Before interacting with a smart contract, you might need to check if the contract supports the right standards. Check the standard detection section of the docs for more infos.

- https://docs.lukso.tech/standards/standard-detection
- https://docs.lukso.tech/standards/tokens/LSP4-Digital-Asset-Metadata#supportedstandardslsp4digitalasset
## Guides

## Related guides
- [Interface Detection - LUKSO Guides](https://docs.lukso.tech/learn/dapp-developer/standard-detection/#interface-detection)
- [Metadata Detection - LUKSO Guides](https://docs.lukso.tech/learn/dapp-developer/standard-detection/#metadata-detection)

- [Standard Detection - LUKSO Guides](https://docs.lukso.tech/learn/dapp-developer/standard-detection/#metadata-detection)
## Metadata standards

Below are the metadata standards used by the scripts in this folder.

- [LSP3 Profile Metadata](https://docs.lukso.tech/standards/universal-profile/lsp3-profile-metadata)
- [LSP4 Digital Asset Metadata](https://docs.lukso.tech/standards/tokens/LSP4-Digital-Asset-Metadata#supportedstandardslsp4digitalasset)
4 changes: 2 additions & 2 deletions transfer-lyx/regular-lyx-transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { ethers } from 'ethers';

// Check if the Ethereum provider is available
// Check if the LUKSO provider is available
// @ts-expect-error This is for the browser
const provider = new ethers.BrowserProvider(window.ethereum);
const provider = new ethers.BrowserProvider(window.lukso);

// https://docs.lukso.tech/learn/dapp-developer/transfer-lyx

Expand Down
2 changes: 1 addition & 1 deletion universal-profile/create-EOA.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const RPC_ENDPOINT = 'https://rpc.testnet.lukso.network/';
// Setup ethers.js provider
const provider = new ethers.JsonRpcProvider(RPC_ENDPOINT);

// Create an Ethereum wallet
// Create a wallet
const wallet = ethers.Wallet.createRandom();

// Print the private key and address
Expand Down