refactor!: Remove Core contracts from LSP7 and LSP8 + use latest @erc725/smart-contracts to remove dependency with OwnableUnset
#974
Conversation
…t vs other LSP packages
CJ42
force-pushed
the
refactor/lsp7-with-erc725-v8
branch
from
452c1d2 to
e3b5539
Compare
…smart-contracts` package
| @@ -46,7 +46,7 @@ | |||
| "lint:solidity": "solhint 'contracts/**/*.sol' && prettier --check 'contracts/**/*.sol'" | |||
| }, | |||
| "dependencies": { | |||
| "@erc725/smart-contracts": "^7.0.0", | |||
| "@erc725/smart-contracts-v8": "file:erc725-smart-contracts-v8-rc0.tgz", | |||
| "@lukso/lsp2-contracts": "*" | |||
There was a problem hiding this comment.
| "@lukso/lsp2-contracts": "*" | |
| "@lukso/lsp2-contracts": "~0.15.0" |
There was a problem hiding this comment.
This is the problem we have between develop and main:
mainhas version numberdevelophas placeholders.
This will all be changed to version numbers soon.
| "@openzeppelin/contracts": "^4.9.6", | ||
| "@lukso/lsp1-contracts": "~0.15.0", | ||
| "@lukso/lsp2-contracts": "~0.15.0", | ||
| "@lukso/lsp4-contracts": "*", | ||
| "@lukso/lsp17contractextension-contracts": "*" |
There was a problem hiding this comment.
Why do some packages have "~0.15.0" and other "*"?
There was a problem hiding this comment.
See my comment above: #974 (comment)
packages/lsp8-contracts/package.json
Outdated
| "@erc725/smart-contracts-v8": "file:erc725-smart-contracts-v8-rc0.tgz", | ||
| "@openzeppelin/contracts": "^4.9.6", | ||
| "@lukso/lsp1-contracts": "~0.15.0", | ||
| "@lukso/lsp2-contracts": "~0.15.0", | ||
| "@lukso/lsp4-contracts": "*", | ||
| "@lukso/lsp17contractextension-contracts": "*" |
There was a problem hiding this comment.
same question regarding versioning
| @@ -42,7 +42,6 @@ | |||
| "lint:solidity": "solhint 'contracts/**/*.sol' && prettier --check 'contracts/**/*.sol'" | |||
| }, | |||
| "dependencies": { | |||
| "@erc725/smart-contracts": "^7.0.0", | |||
| "@openzeppelin/contracts": "^4.9.3" | |||
There was a problem hiding this comment.
same question about package not being updated
|
Since Core has been removed from ERC725, won't this affect as well LSP0 ? |
With the monorepo now, there is not really the concept of "affected packages" anymore. We are not subject anymore to the upgrasdes, and we have control over what we want to upgrade. So in this PR, to keep it scoped, I only upgraded LSP4, 7 and 8 to have ER725 v8 that don't have the (I actually couldn't upgrade LSP0 because of So we can basically decide to release LSP4, 7 and 8 as v0.16.0 without the need to have to upgrade LSP0 + everything else (LSP0 and the other packages are not a blocker anymore). |
ci: add latest solc versions in CI to test compilation
…ck to initial rc version
…endencies build: fix Foundry test failing and `@erc725/smart-contracts` dependency clash between package
What does this PR introduce?
PR Checklist
npm run lint&&npm run lint:solidity(solhint)npm run format(prettier)npm run buildnpm run test