Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to v25.0.0 + aggregation of all my PRs #96

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

paulwer
Copy link
Contributor

@paulwer paulwer commented Jun 19, 2024

closes #62, #64, #47, #45, #89

special thanks to @waynemorphic who has helped us with some of the v25.0.0 upgrades

@paulwer
Copy link
Contributor Author

paulwer commented Jun 19, 2024

@lukin ready for review

@LeftoversTodayAppAdmin
Copy link

Hey folks!

I really appreciate the effort here to generate email templates as well! How do I start utilizing this? I have a fork of keywind with all of my changes in it, should I merge this commit into my fork or just grab the files for the email theme because I dont want it to change what I have customized for my login theme already?

@paulwer
Copy link
Contributor Author

paulwer commented Aug 22, 2024

Hi @LeftoversTodayAppAdmin,
normally we would have to wait until its merged and you can then pull from origin to your fork.

@lukin do you have any kind of updates for us?

@JonathanSchndr
Copy link

@paulwer thanks for your huge effort!

I am also very interested in creating the mail theming via keywind and would be very happy if we had an ETA for it @lukin

@paulwer
Copy link
Contributor Author

paulwer commented Sep 13, 2024

I am currently thinking about forking this repo, and develop it further seperatly, because there has not been any kind of responses for a long time now.

@lukin

@lukin
Copy link
Owner

lukin commented Sep 13, 2024

I apologize for the long wait for my response. You've done an incredible job and I'm happy with most of the changes. As I wrote earlier, I'm unsure about adding the Mailwind dependency, which is not actively supported. Maybe Maizzle is more suited to the project, but unfortunately, I don't have time to adapt that yet.

@TafkaMax
Copy link

Hmm, could we atleast create a PR for updates for keycloak v25? The PR scope could be smaller.

@lukin
Copy link
Owner

lukin commented Sep 13, 2024

Sure. It will be much easier to merge this without checking the other things. 🙂

@paulwer
Copy link
Contributor Author

paulwer commented Sep 13, 2024

Great to hear that <3
I can create an PR without the mail part for now :)

@paulwer paulwer mentioned this pull request Sep 16, 2024
@paulwer
Copy link
Contributor Author

paulwer commented Sep 16, 2024

@lukin done, i removed the pr for emails from this pr.

feel free to reach out to me as you like

@paulwer
Copy link
Contributor Author

paulwer commented Oct 7, 2024

@lukin i changed the code according to the review.

@paulwer
Copy link
Contributor Author

paulwer commented Oct 30, 2024

@lukin any updates?

@TafkaMax
Copy link

TafkaMax commented Nov 12, 2024

I am really hoping the maintainer has some time to review the code. It is unfortunate that project seems at a weird state currently, where there are active forks, but the upstream is the blocker.. Probably will have to create my own fork if updates for newer KC versions are not merged by the end of the year. Just throwing it out there, but maybe it is a time to think about more maintainers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Logout other Sessions
5 participants