-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to v25.0.0 + aggregation of all my PRs #96
base: master
Are you sure you want to change the base?
Conversation
@lukin ready for review |
Hey folks! I really appreciate the effort here to generate email templates as well! How do I start utilizing this? I have a fork of keywind with all of my changes in it, should I merge this commit into my fork or just grab the files for the email theme because I dont want it to change what I have customized for my login theme already? |
Hi @LeftoversTodayAppAdmin, @lukin do you have any kind of updates for us? |
I am currently thinking about forking this repo, and develop it further seperatly, because there has not been any kind of responses for a long time now. |
I apologize for the long wait for my response. You've done an incredible job and I'm happy with most of the changes. As I wrote earlier, I'm unsure about adding the Mailwind dependency, which is not actively supported. Maybe Maizzle is more suited to the project, but unfortunately, I don't have time to adapt that yet. |
Hmm, could we atleast create a PR for updates for keycloak v25? The PR scope could be smaller. |
Sure. It will be much easier to merge this without checking the other things. 🙂 |
Great to hear that <3 |
@lukin done, i removed the pr for emails from this pr. feel free to reach out to me as you like |
@lukin i changed the code according to the review. |
@lukin any updates? |
I am really hoping the maintainer has some time to review the code. It is unfortunate that project seems at a weird state currently, where there are active forks, but the upstream is the blocker.. Probably will have to create my own fork if updates for newer KC versions are not merged by the end of the year. Just throwing it out there, but maybe it is a time to think about more maintainers? |
closes #62, #64, #47, #45, #89
special thanks to @waynemorphic who has helped us with some of the v25.0.0 upgrades