💩 Apply focus capture workaround to dropdown menu trigger

[lukevella]

#934

Summary by CodeRabbit

• Refactor
  • Improved DropdownMenuTrigger component for better ref control and event handling.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	May 18, 2024 5:32am
landing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 18, 2024 5:32am

[coderabbitai]

Walkthrough

The recent update enhances the DropdownMenuTrigger component in dropdown-menu.tsx by utilizing React.forwardRef. This modification provides improved ref handling and event management, specifically stopping propagation on focus capture, leading to more controlled and predictable component behavior.

Changes

Files	Change Summary
packages/ui/src/dropdown-menu.tsx	Modified DropdownMenuTrigger to use React.forwardRef for better ref and event handling, including stopping focus propagation.

🐇🌼
In the code where dropdowns dwell,
A trigger's tale we now retell,
With forward refs and focus keen,
Events are managed, clear and clean.
So hop along, and see the light,
Our UI's future, shining bright!
🌟🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 469fa9b and d0179c9.

Files selected for processing (1)

• packages/ui/src/dropdown-menu.tsx (1 hunks)

Additional comments not posted (1)

packages/ui/src/dropdown-menu.tsx (1)

12-23: Refactor to DropdownMenuTrigger using React.forwardRef looks good.

Verification successful

---

The onFocusCapture event handler in the DropdownMenuTrigger component is not explicitly used in other files. This suggests that the event handler is only defined within the DropdownMenuTrigger component itself. Given this, we need to ensure that the onFocusCapture event handler is functioning as intended within the component.

• The onFocusCapture event handler is defined to stop propagation, which is a common practice to manage focus events in complex UI components.

Since the implementation appears correct and there are no explicit issues found in the usage of DropdownMenuTrigger, the refactor looks good.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify the behavior of the `onFocusCapture` event handler in the `DropdownMenuTrigger` component.

# Test: Search for the usage of `DropdownMenuTrigger` in the project to ensure it's being used correctly.
rg --type typescript $'DropdownMenuTrigger'

Length of output: 77

---

---

Script:

#!/bin/bash
# Description: Verify the behavior of the `onFocusCapture` event handler in the `DropdownMenuTrigger` component.

# Test: Search for the usage of `DropdownMenuTrigger` in the project to ensure it's being used correctly.
rg 'DropdownMenuTrigger' --type-add 'ts:*.{ts,tsx}'

Length of output: 2150

---

---

Script:

#!/bin/bash
# Description: Verify the behavior of the `onFocusCapture` event handler in the `DropdownMenuTrigger` component.

# Test: Search for the usage of `onFocusCapture` in the files where `DropdownMenuTrigger` is used.
files=(
  "apps/web/src/components/participant-dropdown.tsx"
  "apps/web/src/components/user-dropdown.tsx"
  "apps/web/src/components/poll/manage-poll.tsx"
  "apps/web/src/components/feedback.tsx"
  "apps/web/src/components/forms/poll-options-form/month-calendar/month-calendar.tsx"
  "apps/web/src/components/discussion/discussion.tsx"
  "apps/landing/src/components/layouts/page-layout.tsx"
)

for file in "${files[@]}"; do
  rg 'onFocusCapture' "$file"
done

Length of output: 1073