Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix from_pretrained in_channels, etc. #94

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix from_pretrained in_channels, etc. #94

wants to merge 8 commits into from

Conversation

s-rog
Copy link

@s-rog s-rog commented Oct 18, 2019

fix from_pretrained param in_channels
rename existing from_name to _from_name
added new from_name to match from_pretrained signature

@s-rog s-rog mentioned this pull request Oct 18, 2019
Closed
s-rog added 3 commits October 18, 2019 11:10
@s-rog
Update model.py
ccd0b58 
added options to override dropout and drop_connect
@s-rog
Update utils.py
991119f 
add mish to utils
@s-rog
Update model.py
a311651 
added mish as option in set_swish
@s-rog
Copy link
Author

s-rog commented Oct 18, 2019

maybe should have pushed these to another fork... but these commits add dropout and drop_connect options as well as mish (as an option in set_swish)

s-rog added 2 commits October 18, 2019 18:41
@s-rog
Update model.py
e2fab57 
fixed typo in set_swish
@s-rog
Update utils.py
4a6b1f1 
fixed typo in Mish
@s-rog
Copy link
Author

s-rog commented Oct 19, 2019

perhaps it's simpler to have just a from_name function and a pretrained boolean arg?

@s-rog
Update model.py
40bea0b 
consolidated from_name and from_pretrained
@ahmadmughees
Copy link

any update to this? facing the same issue

@s-rog
Copy link
Author

s-rog commented Dec 9, 2019

you can use my fork for now

@ahmadmughees
Copy link

you can use my fork for now

thanks alot. already done that. its working great,

@s-rog
Copy link
Author

s-rog commented Dec 10, 2019

Good to hear! let me know if you think any of the changes I made are unintuitive since I did a little more than just fixing the channels issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-rog @ahmadmughees