Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tags): missing class decorator define #1703

Merged
merged 3 commits into from
Oct 15, 2024
Merged

fix(Tags): missing class decorator define #1703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c45f2d
test(Tags): apply tags decorator on controller class
jackey8616 Oct 15, 2024
7cfb8ff
fix(Tags): missing class decorator definition
jackey8616 Oct 15, 2024
5d91069
test(Tags): adjust test cases to fit class decorator
jackey8616 Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/runtime/src/decorators/tags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export function Tags(...values: string[]): MethodDecorator {
export function Tags(...values: string[]): ClassDecorator & MethodDecorator {
return () => {
return;
};
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/controllers/methodController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const TEST_SEC = {
const ATT_KEY9 = 'x-attKey9';

@Route('MethodTest')
@Tags('MethodTest')
export class MethodController extends Controller {
@Options('Options')
public async optionsMethod(): Promise<TestModel> {
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/swagger/definitionsGeneration/metadata.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ describe('Metadata generation', () => {
throw new Error('Method tags not defined!');
}

expect(method.tags).to.deep.equal(['Tag1', 'Tag2', 'Tag3']);
expect(method.tags).to.deep.equal(['Tag1', 'Tag2', 'Tag3', 'MethodTest']);
});

it('should generate multi response', () => {
Expand Down Expand Up @@ -227,7 +227,7 @@ describe('Metadata generation', () => {
secondSec: ['permission:admin', 'permission:owner'],
});

expect(method.tags).to.deep.equal(['EnumTag1']);
expect(method.tags).to.deep.equal(['EnumTag1', 'MethodTest']);
});

it('should generate success response', () => {
Expand Down
Loading