Refactor(resolver): clear logics #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jackey8616
commented
Apr 3, 2024
•
jackey8616
commented
- Splitting logics of TypeResolver into Transformer class.
- Clean up some nested logics in TypeResolver.
- Rewrite the flow of throwing error with throwUnless instead of if branch.
WoH
reviewed
Apr 4, 2024
| /** | ||
| * Transformer responsible to transforming native ts node into tsoa type. | ||
| */ | ||
| export abstract class Transformer { |
There was a problem hiding this comment.
What do you think about the Transformers registering themselves via a shouldHandle(node) function?
There was a problem hiding this comment.
Can you give me more details about it? I have no clue about shouldHandle function. Oops.
jackey8616
changed the title
|
@WoH |
WoH
reviewed
Apr 5, 2024
| @@ -0,0 +1,28 @@ | |||
| import * as ts from 'typescript'; | |||
| import { Tsoa } from '@tsoa/runtime'; | |||
There was a problem hiding this comment.
Note for the future, we should probably remove this namespace and use a module.
There was a problem hiding this comment.
Once we decouple everything from GIGANTIC type resolver, I think we can do this.
WoH
reviewed
Apr 5, 2024
packages/cli/src/metadataGeneration/transformer/dateTransformer.ts
Outdated
Show resolved
Hide resolved
WoH
reviewed
Apr 5, 2024
WoH
approved these changes
Apr 5, 2024
Co-authored-by: Wolfgang Hobmaier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.