Await apiHandler to handle error in try/catch

[VincentClair]

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you written unit tests?
• Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
• This PR is associated with an existing issue?

Closing issues

closes #1598

Test plan

Checks that a controller method without async keyword throwing an error is caught.

The real problem is if method is not a promise (async keyword), and error throw immediately when building promise, server is no more responding, and we get a time out (actually 5sec in tests).

The problem could resolve in two ways :

• put the buildPromise int the try/catch

  tsoa/packages/runtime/src/routeGeneration/templates/express/expressTemplateService.ts

  Line 41 in efdb468

  const promise = this.buildPromise(methodName, controller, validatedArgs);

• wait for apiHandler to be resolved on generated template

  tsoa/packages/cli/src/routeGeneration/templates/express.hbs

  Line 106 in efdb468

  templateService.apiHandler({

  
  I have chosen to apply both, as I think code will be more robust.

[github-actions]

Hello there VincentClair 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

[WoH]

I think we can always await
@jackey8616

[VincentClair]

agree, but function must be always async: we could replace condition {{#if ../../iocModule}}async {{/if}}line 82 by async directly.

[WoH]

Yeah, that was the ultimate goal, while still making ts not complain about it.

[jackey8616]

I think we can always await @jackey8616

Yes, I think that's good.

[VincentClair]

done

[VincentClair]

is Promise.resolve mandatory : promise ca be waited directly, no? const data = await promise;

[WoH]

No, remove it, assuming this.buildPromise never returns anything but a Promise

[VincentClair]

done

[VincentClair]

Hello @WoH @jackey8616,
How can i help to validate this PR ? Is there something missing ?

[WoH]

No, lgtm 🚀

[denizdogan]

When can we expect a new release with this fix included? Much appreciated