Merge pull request #1713 from chappelo/fix/cast-renamespace-return

fix: error with type casted object with namespace
lukeautry · Nov 11, 2024 · 45de0fa · 45de0fa
2 parents c50fc6d + 33e951a
commit 45de0fa
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/packages/cli/src/metadataGeneration/exceptions.ts b/packages/cli/src/metadataGeneration/exceptions.ts
@@ -11,7 +11,11 @@ export class GenerateMetadataError extends Error {
 }
 
 export class GenerateMetaDataWarning {
-  constructor(private message: string, private node: Node | TypeNode, private onlyCurrent = false) { }
+  constructor(
+    private message: string,
+    private node: Node | TypeNode,
+    private onlyCurrent = false,
+  ) {}
 
   toString() {
     return `Warning: ${this.message}\n${prettyLocationOfNode(this.node)}\n${prettyTroubleCause(this.node, this.onlyCurrent)}`;
@@ -34,9 +38,9 @@ export function prettyLocationOfNode(node: Node | TypeNode) {
 export function prettyTroubleCause(node: Node | TypeNode, onlyCurrent = false) {
   let name: string;
   if (onlyCurrent || !node.parent) {
-    name = node.pos !== -1 ? node.getText() : ((node as any).name?.text || '<unknown name>');
+    name = node.pos !== -1 && node.parent ? node.getText() : (node as any).name?.text || '<unknown name>';
   } else {
-    name = node.parent.pos !== -1 ? node.parent.getText() : ((node as any).parent.name?.text || '<unknown name>');
+    name = node.parent.pos !== -1 ? node.parent.getText() : (node as any).parent.name?.text || '<unknown name>';
   }
   return `This was caused by '${name}'`;
 }
diff --git a/tests/fixtures/controllers/getController.ts b/tests/fixtures/controllers/getController.ts
@@ -112,6 +112,14 @@ export class GetTestController extends Controller {
     return {} as TsoaTest.TestModel73;
   }
 
+  @Get('NamespaceWithTypeCastedObject')
+  public async getNamespaceWithTypeCastedObject() {
+    const test = { value: 'test' };
+    return {
+      value: test as TsoaTest.TestModel73,
+    };
+  }
+
   @Get('Multi')
   public async getMultipleModels(): Promise<TestModel[]> {
     return [new ModelService().getModel(), new ModelService().getModel(), new ModelService().getModel()];

diff --git a/tests/unit/swagger/schemaDetails3.spec.ts b/tests/unit/swagger/schemaDetails3.spec.ts
@@ -4669,6 +4669,12 @@ describe('Definition generation for OpenAPI 3.0.0', () => {
         type: 'object',
       });
     });
+
+    it('should generate schema with namespace type casted object', () => {
+      const response = specDefault.spec.paths['/GetTest/NamespaceWithTypeCastedObject']?.get?.responses;
+
+      expect(response).to.have.all.keys('200');
+    });
   });
 
   describe('@Res responses', () => {