Feature/auth #3
Merged
Feature/auth #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pevel
reviewed
Oct 12, 2018
| }, | ||
| "private": true, | ||
| "dependencies": { | ||
| "@angular/animations": "^6.1.7", | ||
| "@angular/cdk": "^6.2.0", |
There was a problem hiding this comment.
Having ^ in version number may result in different package versions installed on CI server. It's more safe to specify exact version, without any modifier.
There was a problem hiding this comment.
Thanks, good catch, will change that :)
| @@ -14,6 +15,9 @@ describe('AppComponent', () => { | |||
| declarations: [ | |||
| AppComponent | |||
| ], | |||
| providers: [ | |||
| { provide: AuthService, useValue: () => { } } | |||
There was a problem hiding this comment.
I think it makes more sense to useValue: { }. () => { } is a factory.
There was a problem hiding this comment.
Yeah, right. TBH during the time I was fixing UT I put on my list TODO: mock Auth Service ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.