Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scientific colormaps #19

Merged
merged 8 commits into from
Nov 6, 2024
Merged

Add scientific colormaps #19

merged 8 commits into from
Nov 6, 2024

Conversation

Andreas-Piter
Copy link
Member

@Andreas-Piter Andreas-Piter commented Nov 1, 2024

sarvey_plot:

  • -m
    • map_spatiotemporal_consistency.png and map_coherence.png seem to use the same colormaps, but they run in different directions. This is somewhat counter-intuitive.
    • different default colormaps for velocity and DEM correction. (vanimo)
    • revert colormaps for spatiotemporal consistency
    • remove squared sum of residuals
  • -t
    • different default colormaps for velocity and DEM correction (vanimo)
  • -i: change to RomaO
  • -p: change to RomaO

sarvey MTI:

  • different default colormaps for velocity and DEM correction (vanimo)
  • revert colormaps for
    • temporal autocorrelation
    • RMSE of DEM correction and mean velocity
  • create new issue for creating config file with default parameters for plotting

General:

  • Update history
  • Create new tag

@Andreas-Piter Andreas-Piter added the enhancement New feature or request label Nov 1, 2024
@Andreas-Piter Andreas-Piter self-assigned this Nov 1, 2024
@Andreas-Piter Andreas-Piter marked this pull request as draft November 1, 2024 08:31
@Andreas-Piter
Copy link
Member Author

I did not find a suitable substitute for the cmy colormap from mintpy when displaying interferograms.

grafik
CMY colormap from mintpy.

grafik
bamO colormap from crameri

@Andreas-Piter Andreas-Piter linked an issue Nov 1, 2024 that may be closed by this pull request
@Andreas-Piter Andreas-Piter requested a review from mahmud1 November 1, 2024 13:13
@mahmud1
Copy link
Member

mahmud1 commented Nov 4, 2024

The velocity appears good with the new colormap. For the interferogram, I also couldn’t find any suitable colormap in cmcrameri options. I suggest we stick with the current one.

A few suggestions:
• It would be good to have different default colormaps for velocity and DEM correction.
• It would also be useful to allow specifying the colormap as an input argument to sarvey_plot, so if someone prefers something like jet or any other cmcrameri option, they can choose it. I am not sure how complicated this might be for -t that has different colormaps.
• map_spatiotemporal_consistency.png and map_coherence.png seem to use the same colormaps, but they run in different directions. This is somewhat counter-intuitive.

@Andreas-Piter
Copy link
Member Author

Thanks @mahmud1, for your suggestions. I have updated the ToDo list in the top of this Pull request accordingly.

@Andreas-Piter
Copy link
Member Author

For this example the colormap RomaO seems okay to me:
grafik

What do you think, @mahmud1 ?

…lues a bright color for sequential colormaps. Change colormap for interferogram and phases to romaO. Remove figure of squared sum of residuals.
@Andreas-Piter Andreas-Piter marked this pull request as ready for review November 5, 2024 16:35
@mahmud1
Copy link
Member

mahmud1 commented Nov 5, 2024

For this example the colormap RomaO seems okay to me: grafik

What do you think, @mahmud1 ?

The new interfeorgram colormap looks good to me.

mahmud1
mahmud1 previously approved these changes Nov 5, 2024
@Andreas-Piter Andreas-Piter merged commit 55da168 into main Nov 6, 2024
4 of 6 checks passed
@Andreas-Piter Andreas-Piter deleted the enhancement/colormaps branch November 6, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sarvey_plot: Name of folder
2 participants