Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web App capability #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gabrielvincent
Copy link

Hello, Luca!

I've just implemented a Web App capability to Shortly. I needed to include some meta tags on html's head and mess a bit with the CSS. I also included a new function to shortly.js so we could have a different behavior for mobile devices. It is possible to use it right on the mobile browser and, on iOS devices, add them to the home screen as a proper Web App.

I hope yo like it. Congrats for the great work

Cheers.
screen shot 2013-05-12 at 23 11 52

@lucaspiller
Copy link
Owner

Thank's it looks good! Two things before I merge it in though:

  • Remove the .DS_Store files (that's my fault, it should be in the .gitignore, but I've got it in my global one).
  • The Javascript in lib is automatically generated from the CoffeeScript in src. You should update the CoffeeScript, then run make dev which will regenerate the Javascript, then commit both files.

@gabrielvincent
Copy link
Author

Just made the modifications you requested.

On 13/05/2013, at 04:12, Luca Spiller [email protected] wrote:

Thank's it looks good! Two things before I merge it in though:

Remove the .DS_Store files (that's my fault, it should be in the .gitignore, but I've got it in my global one).
The Javascript in lib is automatically generated from the CoffeeScript in src. You should update the CoffeeScript, then run make dev which will regenerate the Javascript, then commit both files.

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants