Novo diálogo de arquivos e remoção de log.printf da main #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISS2718
reviewed
Feb 7, 2024
ISS2718
reviewed
Feb 7, 2024
| return | ||
| } | ||
|
|
||
| // Checks if the file has the .mif extension | ||
| if strings.ToLower(filepath.Ext(f.URI().Path())) != ".mif" { |
There was a problem hiding this comment.
Talvez tirando esse check o erro que será gerado, quando um arquivo de extensão distinta de .mif (tipo o .asm) for carregado, fique um pouco confuso pra um usuário mais leigo do simulador. Porque ele dá um erro na criação do parser só.
|
@lucasgpulcinelli vê se essa mudança faz sentido. |
|
Então, normalmente eu sou meio contra checar extensão pq no final das contas é uma restrição arbitrária, mas você tem razão que alguém que está começando poderia ficar confuso tentando carregar um arquivo de assembly. |
|
Acredito que de código estamos resolvidos então. Só quero ainda testar em todos os sistemas operacionais, quando tiver feito isso concluímos o merge. |
ISS2718
added
macOS test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #4 e um erro comentado em #2 que ocorre em windows.
Para realizar merge ainda é necessário testar em macos.