Skip to content

Commit

Permalink
Update danger (#413)
Browse files Browse the repository at this point in the history
  • Loading branch information
lucas34 authored Jun 29, 2022
1 parent 3fc7447 commit 35df0e7
Showing 1 changed file with 2 additions and 50 deletions.
52 changes: 2 additions & 50 deletions Dangerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,54 +9,6 @@ warn("PR is classed as Work in Progress") if github.pr_title.include? "WIP"
# Warn when there is a big PR
warn("Big PR, try to keep changes smaller if you can") if git.lines_of_code > 500

# Added (or removed) library files need to be added (or removed) from the
# Carthage Xcode project to avoid breaking things for our Carthage users.
added_swift_library_files = !(git.added_files.grep(/Sources.*\.swift/).empty?)
deleted_swift_library_files = !(git.deleted_files.grep(/Sources.*\.swift/).empty?)
modified_carthage_xcode_project = !(git.modified_files.grep(/SwiftQueue\.xcodeproj/).empty?)
if (added_swift_library_files || deleted_swift_library_files) && !modified_carthage_xcode_project
fail("Added or removed library files require the Carthage Xcode project to be updated.")
end

# Check for dependencies update
podspec_updated = !git.modified_files.grep(/SwiftQueue.podspec/).empty?

cartfile_updated = !git.modified_files.grep(/Cartfile/).empty?
cartfile_resolved_updated = !git.modified_files.grep(/Cartfile.resolved/).empty?

spm_updated = !git.modified_files.grep(/Package.swift/).empty?
spm_resolved_updated = !git.modified_files.grep(/Package.resolved/).empty?

# Warn if Cartfile is updated but not Cartfile.resolved
if cartfile_updated && !cartfile_resolved_updated
warn("The `Cartfile` has been updated but not the `Cartfile.resolved`. Did you forgot to run `carthage update` ?")
end

# Warn if Package.swift is updated but not Package.resolved
if spm_updated && !spm_resolved_updated
warn("The `Package.swift` has been updated but not the `Package.resolved`. Did you forgot to run `swift package update` ?")
end

# Warn if Package.resolved and cartfile.resolved are not updated at the same time
if (cartfile_resolved_updated && !spm_resolved_updated) || (spm_resolved_updated && !cartfile_resolved_updated)
warn("The `Package.resolved` or `cartfile.resolved` was updated, but not both. Did you forgot to run `carthage update` or `swift package update`?")
end

# Warn if podpec has been update but not Cartfile or Package.swift
if podspec_updated && (!cartfile_updated || !spm_updated)
warn("The `podspec` was updated, but there were no changes in either the `Cartfile` nor `Package.swift`. Did you forget updating `Cartfile` or `Package.swift`?")
end

# Warn if cartfile has been update but not podspec or Package.swift
if cartfile_updated && (!podspec_updated || !spm_updated)
warn("The `Cartfile` was updated, but there were no changes in either the `podspec` nor `Package.swift`. Did you forget updating `podspec` or `Package.swift`?")
end

# Warn if Package.swift has been update but not podspec or Cartfile
if spm_updated && (!podspec_updated || !cartfile_updated)
warn("The `Package.swift` was updated, but there were no changes in either the `podspec` nor `Cartfile`. Did you forget updating `podspec` or `Cartfile`?")
end

# Warn when library files has been updated but not tests.
tests_updated = !git.modified_files.grep(/Tests/).empty?
if has_app_changes && !tests_updated
Expand All @@ -68,5 +20,5 @@ swiftlint.lint_files

# Run prose
prose.ignored_words = ["SPM", "CFBundleVersion", "JobInfo", "compactMap", "lastError", "args", "enum", "SwiftQueue", "JobBuilder", "SwiftQueueManager", "onError", "carthage", "Rechability", "Cleanup", "TimeInterval", "SingleInstance", "Swiftlint", "travis", "params", "JobCompletion", "inSecond", "onRetry", "onRemove", "UniqueUUID", "OperationQueue", "SwiftQueueJob", "uuid", "DEPS", "serializer", "deserialization", "Deserialize"]
# prose.ignore_numbers = true
# prose.check_spelling
prose.ignore_numbers = true
prose.check_spelling

0 comments on commit 35df0e7

Please sign in to comment.