Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: obeys esbuild's external argument #102

Merged
merged 3 commits into from
Jan 22, 2024
Merged

fix: obeys esbuild's external argument #102

merged 3 commits into from
Jan 22, 2024

Conversation

BlackAsLight
Copy link
Contributor

This pull requests fixes this issue #31

The plugin now handles esbuild's external argument properly accepting wildcards

Copy link
Owner

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lucacasonato
Copy link
Owner

I'll add a test before landing this.

@lucacasonato lucacasonato merged commit b4cc95a into lucacasonato:main Jan 22, 2024
6 checks passed
@lucacasonato lucacasonato mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants