Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no sq] Enable ipv6_server by default #15739

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[no sq] Enable ipv6_server by default #15739

wants to merge 2 commits into from

Conversation

sfan5
Copy link
Collaborator

@sfan5 sfan5 commented Jan 31, 2025

This makes it so that if you have IPv6 and enable server announcements you automatically arrive at a configuration that actually works (domain or not).
Previously if you had IPv6 configured on your server and maybe even a domain, the server list would reject you because the server can't actually be reached over IPv6 by default.

Implications:

  • the IP returned in get_player_information will now be ::ffff:1.2.3.4 by default. I think most mods handle this.

Note: this PR was written on a train.

To do

This PR is a Ready for Review.

@sfan5 sfan5 added @ Server / Client / Env. Feature ✨ PRs that add or enhance a feature labels Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants