Fix sounds playing for objects not sent to the client #15734
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes sounds playing for object not sent to the client.
Emojigit
force-pushed
the
fork-20250130-fix-ghost-sounds
branch
from
6ece2ad to
790c032
Compare
sfan5
added
Trivial
|
Well, not fixed ye... |
|
Even if it doesn't fix the issue you're having the code changes make sense to me. How about merging it in this state? |
|
Okay :-D |
appgurueu
reviewed
Feb 8, 2025
sfan5
removed
the
Action / change needed
sfan5
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes sounds playing for objects not sent to the client.Does not fix, but make sense anyways.To do
This PR is Ready for Review.
How to test
Footnotes
I don't know how to reproduce this bug reliably. However, if you're a regular player of LinuxForks, 1F616EMO Survival Server, or any servers with extensive Advtrains network, you should have encountered this at least once. ↩