filesys: replace goto by #else to omit compile warning #15711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling on a system other than Linux, you get the warning: ``` [ 72%] Building CXX object src/CMakeFiles/luanti.dir/filesys.cpp.o .../luanti/src/filesys.cpp:516:1: warning: unused label 'fallback' [-Wunused-label] 516 | fallback: ``` Fix this by using an else instead of a goto
appgurueu
added
Trivial
appgurueu
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling on a system other than Linux, you get the warning:
Fix this by using an
#elseinstead of a goto.Add compact, short information about your PR for easier understanding:
I was unsure if I should have guarded the goto label with another
#ifdefinstead as I recall back in the day the#elsenot being as supported as the standard#ifdef. However I think it is a non-issue these days.To do
This PR is Ready for Review.