-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose client version information in non-debug builds #15708
Open
rollerozxa
wants to merge
10
commits into
luanti-org:master
Choose a base branch
from
rollerozxa:patch-4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−5
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3b8dfab
Explose client version information in non-debug builds
rollerozxa 1acfbbe
trim trailing whitespace
rollerozxa 7d137ef
Better wording
rollerozxa 6961763
Update lua_api.md
rollerozxa fa4397d
More wording update
rollerozxa 1f0f872
Update doc/lua_api.md
rollerozxa f833477
Move back everything but version_string behind debug check
rollerozxa 69ce690
update docs to go along
rollerozxa 4f0ea4a
put them back as comments
rollerozxa 953bb87
Add `core.protocol_versions` for modder convenience
appgurueu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
-- c.f. https://content.luanti.org/api/minetest_versions/ | ||
-- see also src/network/networkprotocol.cpp | ||
core.protocol_versions = { | ||
["5.0"] = 37, | ||
["5.1"] = 38, | ||
["5.2"] = 39, | ||
["5.3"] = 39, | ||
["5.4"] = 39, | ||
["5.5"] = 40, | ||
["5.6"] = 41, | ||
["5.7"] = 42, | ||
["5.8"] = 43, | ||
["5.9"] = 44, | ||
["5.10"] = 46, | ||
["5.11"] = 47, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you make it explicit on
core.features
andcore.has_feature
above that they're for server-side feature detection? so we get a clear differentiation between server-side feature detection and client--side feature detection