-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace object visual by enum #15681
Open
cx384
wants to merge
3
commits into
luanti-org:master
Choose a base branch
from
cx384:object_visual_enum
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cx384
added
Maintenance
Tasks to keep the codebase and related parts in order, including architectural improvements
Code quality
labels
Jan 15, 2025
cx384
commented
Jan 15, 2025
cx384
force-pushed
the
object_visual_enum
branch
from
January 15, 2025 19:34
d5757fe
to
0e30370
Compare
Desour
reviewed
Jan 16, 2025
Thanks for the review, it should be fixed now. |
3 tasks
Desour
reviewed
Jan 16, 2025
sfan5
reviewed
Jan 17, 2025
cx384
force-pushed
the
object_visual_enum
branch
from
January 19, 2025 13:16
b0b9c7c
to
543713e
Compare
cx384
force-pushed
the
object_visual_enum
branch
from
January 25, 2025 13:58
e7565ec
to
4525e12
Compare
Rebased |
unfortunately another rebase is required. I'm totally in favor of such quality change. |
cx384
force-pushed
the
object_visual_enum
branch
from
January 27, 2025 11:27
4525e12
to
4af592e
Compare
sfan5
reviewed
Jan 27, 2025
sfan5
reviewed
Jan 27, 2025
Co-authored-by: sfan5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code quality
Maintenance
Tasks to keep the codebase and related parts in order, including architectural improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the
visual
variable of theObjectProperties
class by an enum.OBJECTVISUAL_
prefix, since this way it is more similar to the existing code, e.g. the HUD enums. Tell me in case you prefer something else.To do
Ready for Review.
How to test
👁️ 👁️