Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix always waving semitransparent liquid regression #15673

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix always waving semitransparent liquid regression #15673

merged 1 commit into from
Jan 13, 2025

Conversation

Desour
Copy link
Member

@Desour Desour commented Jan 12, 2025

See a6293b9.

cc @sfan5

To do

This PR is a Ready for Review.

How to test

  • Look at mtg river water (which has use_texture_alpha = "blend", but is not waving).
  • It should not wave.
  • Try with water reflections (setting depends on shadows), it still has to be gummi bear liquid.

@sfan5 sfan5 added One approval ✅ ◻️ Regression Something that used to work no longer does labels Jan 12, 2025
@sfan5 sfan5 merged commit 2bfcd45 into luanti-org:master Jan 13, 2025
16 checks passed
@Desour Desour deleted the fix_waving_riverwater branch January 13, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug @ Client rendering One approval ✅ ◻️ Regression Something that used to work no longer does
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Desour @sfan5