More Configurability and Working Signatures For Required Routes #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
otobongfp
commented
Sep 6, 2024
•
otobongfp
commented
- Added the delete feature to the inbox - controller & service.
- Added Network ID to the config so that a user can set it, but by default the ID is set mainnet - "L".
- Fixed how the http-signatures lib gets the actual url signed by the client..
CryptoTabaluga
approved these changes
Sep 13, 2024
CryptoTabaluga
approved these changes
Sep 13, 2024
jasny
requested changes
Sep 16, 2024
jasny
requested changes
Sep 27, 2024
| import { verify } from '@ltonetwork/http-message-signatures'; | ||
|
|
||
| export const lto = new LTO(); |
There was a problem hiding this comment.
Don't create a global LTO object. You don't know the network.
Comment on lines
9
to
13
| private lto: LTO; | ||
|
|
||
| constructor() { | ||
| this.lto = new LTO(); | ||
| } |
jasny
reviewed
Sep 27, 2024
| const network = getNetwork(walletAddress); | ||
|
|
||
| //switch to testnet if address is testnet | ||
| if (network == 'T') this.lto = new LTO(network); |
There was a problem hiding this comment.
This never switches back to mainnet. No need to switch though. Just create a new LTO object for each request.
const lto = new LTO(network)
jasny
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.