Skip to content

Commit

Permalink
security patch: model downloading policy is updated
Browse files Browse the repository at this point in the history
doesn't allow model downloading if security level is high and ComfyUI is remotely accessible
  • Loading branch information
ltdrdata committed Jul 21, 2024
1 parent f06afbd commit 93bc2ed
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion glob/manager_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import cm_global
from manager_util import *

version = [2, 46, 3]
version = [2, 46, 4]
version_str = f"V{version[0]}.{version[1]}" + (f'.{version[2]}' if len(version) > 2 else '')


Expand Down
8 changes: 8 additions & 0 deletions glob/manager_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -985,6 +985,14 @@ async def install_model(request):

model_path = get_model_path(json_data)

if not is_allowed_security_level('middle'):
print(f"ERROR: To use this action, a security_level of `middle or below` is required. Please contact the administrator.")
return web.Response(status=403)

if not json_data['name'].endswith('.safetensors') and not is_allowed_security_level('high'):
print(f"ERROR: To use this feature, you must set '--listen' to a local IP and set the security level to 'middle' or 'weak'. Please contact the administrator.")
return web.Response(status=403)

res = False

try:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[project]
name = "comfyui-manager"
description = "ComfyUI-Manager provides features to install and manage custom nodes for ComfyUI, as well as various functionalities to assist with ComfyUI."
version = "2.46.3"
version = "2.46.4"
license = "LICENSE"
dependencies = ["GitPython", "PyGithub", "matrix-client==0.4.0", "transformers", "huggingface-hub>0.20", "typer", "rich", "typing-extensions"]

Expand Down

0 comments on commit 93bc2ed

Please sign in to comment.