U/yoachim/fo plot fix #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhiannonlynne
approved these changes
Aug 6, 2024
| @@ -486,7 +486,7 @@ def ddfBatch( | |||
| for f in filterlist: | |||
| fieldsqls[f] = sqls[f] | |||
| else: | |||
| fieldsql = f"note like '%{fieldname}%'" | |||
| fieldsql = f"scheduler_note like '%{fieldname}%'" | |||
There was a problem hiding this comment.
This one we could use "target_name", but scheduler_note works too.
| @@ -144,7 +144,7 @@ def glanceBatch( | |||
| bundle_list.append(bundle) | |||
|
|
|||
| # alt az of long gaps | |||
| sql = "note = 'long'" | |||
| sql = "scheduler_note = 'long'" | |||
There was a problem hiding this comment.
Sigh, I see your point about scheduler_note vs note being embedded in many places.
And true, a whole separate colmap just for this one change is likely overkill.
yoachim
force-pushed
the
u/yoachim/fo_plot_fix
branch
from
ec1479b
to
71f3610
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix so FO plot is generated again. Add a switch so
ddf_batchcan be run using older coordinates.