color and slope metrics #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| slope_length=3.0, | ||
| time_col="observationStartMJD", | ||
| units="#", | ||
| metric_name="ColorSlope", |
There was a problem hiding this comment.
I'm curious because I see this pattern a lot -- but why specify the metric_name here when it's the same as what will be constructed by default?
There was a problem hiding this comment.
I bet I was probably planning on having one metric with a kwarg rather then two, so I'd be setting the metric_name to run it different ways.
rhiannonlynne
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pair of metrics that can be used as proxies for how well we will recover/classify transients like KNe.