Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pandas dep warnings #401

Merged
merged 1 commit into from
Mar 29, 2024
Merged

fix pandas dep warnings #401

merged 1 commit into from
Mar 29, 2024

Conversation

yoachim
Copy link
Member

@yoachim yoachim commented Mar 29, 2024

Fixes several pandas deprecation warnings. Unit tests pass, and example notebook looks identical before and after update. Might not be compatible with older pandas versions.

@rhiannonlynne
Copy link
Member

I feel like there must be a more elegant way to do this than just copying the columns but .. it works and it's clear that we're not making new data (which should make some other people happy) and it is likely fairly robust about pandas. I think this should still work with older versions.
Are you getting (new) warnings about copying or making slices of the pandas data with this change?

@yoachim yoachim merged commit d0f51a8 into main Mar 29, 2024
6 of 9 checks passed
@rhiannonlynne rhiannonlynne deleted the tickets/OPSIM-1142 branch April 15, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants