-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PREOPS-4949: Add stackers useful for schedview (Teff and dayobs related) #399
Conversation
00feb6a
to
82c8594
Compare
I realized I had a concern that if there were two bundles with TeffStacker but one "normed" and one not, that they might run at the same time and have a conflict about the t_eff column. However, apparently we built MAF better than that and it does the right thing (runs them separately, rewrites the t_eff values, and comes up with the correct answers. Yay!
produces
as expected. values from the previous TeffMetric for the same run: |
@@ -0,0 +1,145 @@ | |||
__all__ = ["TEFF_FIDUCIAL_DEPTH", "TEFF_FIDUCIAL_EXPTIME", "TeffStacker"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might as well export "compute_teff" as well, though maybe? (especially if exporting the fiducial values).
In theory, you could use the compute_teff
with a pandas data frame using apply
, although it may be better overall (i.e. from schedview) to just use the
maf.get_sim_data() method, pointing to the visit database in question, and add the stackers you want.
@@ -106,9 +106,12 @@ def glanceBatch( | |||
bundle_list.append(bundle) | |||
|
|||
# Total effective exposure time | |||
metric = metrics.TeffMetric(m5_col=colmap["fiveSigmaDepth"], filter_col=colmap["filter"], normed=True) | |||
metric = metrics.MeanMetric(col="t_eff") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh, right -- when using Normed stackers, the sum becomes a MeanMetric.
82c8594
to
c202434
Compare
I'll do the addition of the plotters we discussed as a separate PR.