Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniformFoMMetric summary metric #396

Closed
wants to merge 1 commit into from
Closed

Conversation

rmandelb
Copy link
Collaborator

@rmandelb rmandelb commented Mar 15, 2024

This draft PR is for the new summary metric (based on this notebook). The work is not yet complete, with 2 TODOs listed at the top and one in the middle (comment beginning with ###). These include:

  • Figuring out how to constrain it to all exposures up to a particular year (self-consistently for the metric on which this is based and when calling the 3x2pt FoM metric in run()).
  • Figuring out how to put in the constraints on dust, DDFs, twilight exposures (self-consistently for the metric on which this is based and when calling the 3x2pt FoM metric in run()).
  • Actually calling the 3x2pt FoM metric -- I wasn't quite sure how to do that from within MAF.

I plan to work on it more in the morning, but there's already a lot there so I wanted to get some eyes on it. Advice on the above is welcome. (With these things still to do, I haven't been able to run this yet, so I am sure there are bugs.)

@rmandelb
Copy link
Collaborator Author

Boris has made great progress towards reformulating this metric and incorporating it into his code in #397 . We have a few more checks to do once NERSC is back up tomorrow, but I'm confident that his approach is going to work, so I'm closing this draft PR. Thanks, Peter and Lynne, for all the advice about how to formulate these new summary metrics.

@rmandelb rmandelb closed this Apr 17, 2024
@rhiannonlynne rhiannonlynne deleted the u/rmandelb/uniformfom branch September 12, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant