-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental template metric #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize this is a bit of a pain but can I request a couple of changes?
Since the time this metric was prototyped in the various notebooks, we did move from camelCase to snake_case .. this is a truly minor thing, but would be nice if the variables in the metric were consistent (dataSlice -> data_slice, etc).
Please run isort to fix the import ordering.
can you please add a unit test, just with some example inputs and then ensuring the metric returns the values expected?
Edit to say never mind about the merge problem, I was misinterpreting the unit test failures. |
8c810f9
to
78851ce
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
- Coverage 55.33% 55.25% -0.09%
==========================================
Files 304 305 +1
Lines 29609 29681 +72
Branches 4282 4285 +3
==========================================
+ Hits 16385 16400 +15
- Misses 12281 12338 +57
Partials 943 943 ☔ View full report in Codecov by Sentry. |
@ebellm you can merge this is you'd like, or I can go ahead. If you have additional changes you'd like to add, let me know and we can wait. |
7a6a9c2
to
8bc959e
Compare
8bc959e
to
e5781f8
Compare
No description provided.