Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental template metric #389

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Incremental template metric #389

merged 9 commits into from
Feb 13, 2024

Conversation

ebellm
Copy link
Contributor

@ebellm ebellm commented Jan 19, 2024

No description provided.

Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is a bit of a pain but can I request a couple of changes?

Since the time this metric was prototyped in the various notebooks, we did move from camelCase to snake_case .. this is a truly minor thing, but would be nice if the variables in the metric were consistent (dataSlice -> data_slice, etc).
Please run isort to fix the import ordering.
can you please add a unit test, just with some example inputs and then ensuring the metric returns the values expected?

@rhiannonlynne
Copy link
Member

rhiannonlynne commented Jan 19, 2024

Edit to say never mind about the merge problem, I was misinterpreting the unit test failures.
Basically, instead - run black.

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (87dd9cc) 55.33% compared to head (78851ce) 55.25%.
Report is 3 commits behind head on main.

❗ Current head 78851ce differs from pull request most recent head e5781f8. Consider uploading reports for the commit e5781f8 to get more accurate results

Files Patch % Lines
...bin_sim/maf/metrics/incremental_template_metric.py 19.71% 57 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #389      +/-   ##
==========================================
- Coverage   55.33%   55.25%   -0.09%     
==========================================
  Files         304      305       +1     
  Lines       29609    29681      +72     
  Branches     4282     4285       +3     
==========================================
+ Hits        16385    16400      +15     
- Misses      12281    12338      +57     
  Partials      943      943              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhiannonlynne
Copy link
Member

@ebellm you can merge this is you'd like, or I can go ahead. If you have additional changes you'd like to add, let me know and we can wait.

@ebellm ebellm merged commit e9c1862 into lsst:main Feb 13, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants