Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSIM-1107 Documentation restructure #387

Merged
merged 26 commits into from
Mar 4, 2024
Merged

Conversation

rhiannonlynne
Copy link
Member

Restructuring the documentation to work for the Rubin user guide.
There are lots of ruff updates as well, to bring documentation lines into line length compliances and sometimes to update and improve the documentation too.

@rhiannonlynne rhiannonlynne marked this pull request as ready for review February 27, 2024 18:53
@rhiannonlynne
Copy link
Member Author

This still isn't finished, but I'm running out of steam and will have to just make another ticket to finish ruff and docstrings in the remainder of the MAF module.
It does make the rest a lot better though.

Copy link
Collaborator

@ehneilsen ehneilsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Massive" is right!
I had lots of minor suggestions, inconsistently stated (if I had the same suggestion for a number of places, I didn't always make the comment for all places), but nothing that should stop the merge.

@@ -12,14 +12,16 @@ def make_metric_list(outfile):
# Print header
print(".. py:currentmodule:: rubin_sim.maf", file=f)
print("", file=f)
print(".. _rubin_sim.maf_metricist:", file=f)
print(".. _maf-metric-list:", file=f)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A slightly slicker way to do all this is to use context managers to open the file and redirect stdout, and then a bare print statement with a multi-line string, but of course this is fine.

rubin_sim/moving_objects/ooephemerides.py Outdated Show resolved Hide resolved
If updating self, resets fnu to None.
Method will first check if resampling needs to be done or not, unless 'force' is True.
Method will first check if resampling needs to be done or not,
unless 'force' is True.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a parameters section could be added here.

rubin_sim/selfcal/generate_catalog.py Outdated Show resolved Hide resolved
rubin_sim/selfcal/solver.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 41.72185% with 88 lines in your changes are missing coverage. Please review.

Project coverage is 58.31%. Comparing base (78851ce) to head (b263fb5).
Report is 17 commits behind head on main.

Files Patch % Lines
...contrib/calculate_lsst_field_visibility_astropy.py 11.53% 23 Missing ⚠️
.../lss_obs_strategy/galaxy_counts_metric_extended.py 14.28% 6 Missing ⚠️
...s_strategy/galaxy_counts_with_pixel_calibration.py 0.00% 6 Missing ⚠️
rubin_sim/maf/maf_contrib/star_counts/coords.py 0.00% 6 Missing ⚠️
rubin_sim/maf/maps/create_gaia_density_map.py 0.00% 5 Missing ⚠️
rubin_sim/phot_utils/sed.py 0.00% 5 Missing ⚠️
rubin_sim/maf/maf_contrib/triplet_metric.py 0.00% 4 Missing ⚠️
...ubin_sim/maf/maf_contrib/star_count_mass_metric.py 40.00% 3 Missing ⚠️
rubin_sim/maf/maf_contrib/star_count_metric.py 50.00% 3 Missing ⚠️
rubin_sim/maf/metrics/simple_metrics.py 75.00% 2 Missing and 1 partial ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
+ Coverage   55.25%   58.31%   +3.05%     
==========================================
  Files         305      295      -10     
  Lines       29681    28102    -1579     
  Branches     4285     3989     -296     
==========================================
- Hits        16400    16387      -13     
+ Misses      12338    10770    -1568     
- Partials      943      945       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhiannonlynne rhiannonlynne merged commit f0cb615 into main Mar 4, 2024
5 of 11 checks passed
@rhiannonlynne rhiannonlynne deleted the tickets/OPSIM-1107 branch March 4, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants