Switched interp2d to RectBivariateSpline #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
- Coverage 55.33% 55.33% -0.01%
==========================================
Files 304 304
Lines 29608 29609 +1
Branches 4281 4282 +1
==========================================
Hits 16385 16385
Misses 12281 12281
- Partials 942 943 +1 ☔ View full report in Codecov by Sentry. |
rhiannonlynne
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code used an interpolation scheme from a pre-calculated table to obtain the expected QSO number counts as a function of redshift and magnitude.
The original code used scipy.interpolate.interp2d with a cubic spline, but this routine is being deprecated. I have updated the code to instead use scipy.interpolate.RectBivariateSpline also with a cubic spline. Testing shows that the results are the same for a range of redshift and magnitudes between the two methods.