Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSIM:1050 Update m52snr and add y-band parallax metric #360

Merged
merged 14 commits into from
Sep 19, 2023

Conversation

rhiannonlynne
Copy link
Member

@rhiannonlynne rhiannonlynne commented Sep 16, 2023

Many of the commits in this PR are updating line length in doc strings, moving a bit more code to snake_case from camelCase, removing unnecessary or unused code (imports or values that were not used), updating super() calls to remove the / self arguments, or standardizing metric API ("Metric" at the end of metric classnames, metric_name doesn't need to be a kwarg if the default is the same as the class name).

The meaningful changes though are:

  • addition of fwhm_500 to the ModelObservatory attributes (this was helpful for a test of m5 difference basis functions, when changing the input seeing .. in order to track what the 'original' value was).
  • update FO plot to use sky and n_visits kwargs correctly in the summary metrics printed in the legend

and the bigger changes:

  • updating m52snr to use a more accurate SNR formula
  • updating the astrometric precision estimate to also include the systematic floor (instead of having to add this separately in the returned values) -- moving it to the function should make it easier for other users to remember to include this
  • adding a y-band parallax uncertainty metric to the astrometry_batch

@rhiannonlynne rhiannonlynne changed the title Tickets/opsim 1050 OPSIM:1050 Update m52snr and add y-band parallax metric Sep 18, 2023
Copy link
Member

@yoachim yoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor things.

rubin_sim/scheduler/model_observatory/model_observatory.py Outdated Show resolved Hide resolved
rubin_sim/maf/utils/astrometry_utils.py Outdated Show resolved Hide resolved
rubin_sim/maf/utils/astrometry_utils.py Outdated Show resolved Hide resolved
@rhiannonlynne rhiannonlynne merged commit 6eb5518 into main Sep 19, 2023
3 of 4 checks passed
@rhiannonlynne rhiannonlynne deleted the tickets/OPSIM-1050 branch September 19, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants