make it possible to replace seeing, clouds, downtime in ModelObservatory #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoachim
force-pushed
the
tickets/OPSIM-1022
branch
from
fb29eff
to
628134e
Compare
ehneilsen
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
This looks like it will do what I need it to.
I think the naming, separating seeing_data from the seeing model, might be a little confusing without context. For example, it looks like I can pass a function that simulates clouds or seeing with a stochastic model instead of a data set as "cloud_data" or "seeing_data" (and I expect to actually write such simulators), but intuitively this seems like more of a model to me than data. But really, this is a minor quibble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to add in arbitrary cloud, seeing, and downtime to the model observatory.