DM-47357: Explicitly configure timeouts for fsspec #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default timeout and number of TCP connections kept alive by fsspec' HTTPFileSystem are not suitable for production conditions so we set them to more reasonable values based on observed behavior.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 86.89% 86.80% -0.10%
==========================================
Files 27 27
Lines 4656 4690 +34
Branches 564 566 +2
==========================================
+ Hits 4046 4071 +25
- Misses 466 474 +8
- Partials 144 145 +1 ☔ View full report in Codecov by Sentry. |
This feature has shown undesired behavior in some situations and the root cause of that behavior is not totally understood. We provide the possibility of explicitly enable that feature if proven useful or for testing purposes.
When HttpResourcePath is configured with support for to_fsspec() disabled a ImportError exception must be raised to signal the caller that that method is not supported. Make the exception message explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default timeout and number of TCP connections kept alive by fsspec' HTTPFileSystem are not suitable for production conditions so we set them to more reasonable values based on observed behavior.
Checklist
doc/changes