Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-42091: Remove long deprecated s3 utilities #96

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

timj
Copy link
Member

@timj timj commented Oct 1, 2024

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.47%. Comparing base (754fa0f) to head (0cf3e5c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   86.18%   86.47%   +0.29%     
==========================================
  Files          27       27              
  Lines        4646     4622      -24     
  Branches      956      948       -8     
==========================================
- Hits         4004     3997       -7     
+ Misses        487      470      -17     
  Partials      155      155              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj requested a review from dhirving October 1, 2024 23:30
@timj
Copy link
Member Author

timj commented Oct 1, 2024

The python 3.13 failure is going to fix itself because 3.13-rc3 has the text added back that was removed in rc2 (and was present in rc1).

@timj timj merged commit cc6cc24 into main Oct 1, 2024
16 of 17 checks passed
@timj timj deleted the tickets/DM-42091 branch October 1, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants