Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45978: Add webdav support to ResourcePath.to_fsspec #94

Merged
merged 6 commits into from
Oct 1, 2024

Address reviewer's comments

729aa57
Select commit
Loading
Failed to load commit list.
Merged

DM-45978: Add webdav support to ResourcePath.to_fsspec #94

Address reviewer's comments
729aa57
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 1, 2024 in 1s

86.18% (-0.84%) compared to 0f26220

View this Pull Request on Codecov

86.18% (-0.84%) compared to 0f26220

Details

Codecov Report

Attention: Patch coverage is 76.49123% with 67 lines in your changes missing coverage. Please review.

Project coverage is 86.18%. Comparing base (0f26220) to head (729aa57).

Files with missing lines Patch % Lines
python/lsst/resources/http.py 67.44% 51 Missing and 5 partials ⚠️
tests/test_http.py 90.26% 7 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   87.01%   86.18%   -0.84%     
==========================================
  Files          27       27              
  Lines        4460     4646     +186     
  Branches      905      956      +51     
==========================================
+ Hits         3881     4004     +123     
- Misses        431      487      +56     
- Partials      148      155       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.