Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-46025: Force a default AWS region for S3 tests #93

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

timj
Copy link
Member

@timj timj commented Aug 28, 2024

This prevents problems when there is a local override in ~/.aws/config.

Note that we use "us-east-1" for all tests. "us-west-1" does not work. In theory MOTO_ALLOW_NONEXISTENT_REGION could be set to allow an arbitrary fake region to be used but that does not seem to work with our tests at present.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

This prevents problems when there is a local override in
~/.aws/config.

Note that we use "us-east-1" for all tests. "us-west-1" does
not work. In theory MOTO_ALLOW_NONEXISTENT_REGION could be
set to allow an arbitrary fake region to be used but that
does not seem to work with our tests at present.
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.01%. Comparing base (9adbd98) to head (bc211d0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   87.01%   87.01%           
=======================================
  Files          27       27           
  Lines        4460     4460           
  Branches      905      905           
=======================================
  Hits         3881     3881           
  Misses        431      431           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj merged commit 74ad8d1 into main Aug 30, 2024
17 checks passed
@timj timj deleted the tickets/DM-46025 branch August 30, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants