Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable S3 transfer optimizations #103

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhirving
Copy link
Contributor

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Sorry, something went wrong.

Copy link

codecov bot commented Dec 18, 2024

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
199 6 193 2
View the top 3 failed tests by shortest run time
tests/test_s3.py::S3ReadWriteTestCase::test_implicit_default_threading
Stack Traces | 0.286s run time
self = <tests.test_s3.S3ReadWriteTestCase testMethod=test_implicit_default_threading>

    def test_implicit_default_threading(self):
        S3ResourcePath.use_threads = None
        boto_default = signature(boto3.s3.transfer.TransferConfig).parameters["use_threads"].default
        test_resource_path = self.root_uri.join("test_file.dat")
>       self.assertEqual(test_resource_path._transfer_config.use_threads, boto_default)
E       AssertionError: False != True

tests/test_s3.py:226: AssertionError
tests/test_s3.py::S3WithProfileReadWriteTestCase::test_implicit_default_threading
Stack Traces | 0.347s run time
self = <tests.test_s3.S3WithProfileReadWriteTestCase testMethod=test_implicit_default_threading>

    def test_implicit_default_threading(self):
        S3ResourcePath.use_threads = None
        boto_default = signature(boto3.s3.transfer.TransferConfig).parameters["use_threads"].default
        test_resource_path = self.root_uri.join("test_file.dat")
>       self.assertEqual(test_resource_path._transfer_config.use_threads, boto_default)
E       AssertionError: False != True

tests/test_s3.py:226: AssertionError
tests/test_s3.py::S3WithProfileReadWriteTestCase::test_threading_true
Stack Traces | 0.355s run time
self = <tests.test_s3.S3WithProfileReadWriteTestCase testMethod=test_threading_true>

    def test_threading_true(self):
        with mock.patch.dict(os.environ, {"LSST_S3_USE_THREADS": "True"}):
            S3ResourcePath.use_threads = None
            test_resource_path = self.root_uri.join("test_file.dat")
>           self.assertTrue(test_resource_path._transfer_config.use_threads)
E           AssertionError: False is not true

tests/test_s3.py:220: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant